change CSDS to populate new generic_xds_configs field #27794
Conversation
markdroth
added
the
release notes: no
There was a problem hiding this comment.
The new CSDS is indeed much easier to use. Besides C++, we might also need to update:
- Python's CSDS test: src/python/grpcio_tests/tests/csds/test_csds.py (we can add
unittest.skip("TODO(lidiz) use generic_xds_config field")to both test classes for now) - xDS interop test framework: I will update them in parallel of this PR.
|
If you want to send me a PR with the changes for src/python/grpcio_tests/tests/csds/test_csds.py, I can merge that into this PR, so that we can merge both changes into master at the same time. Also, were you going to change the xDS interop tests to accept both old and new CSDS formats, or just change it to use the new one? If the former, then that probably needs to be done before this is merged. If the latter, then we probably need to coordinate the changes in all languages, or else we'll break the dashboard. I think the former would be easier. We probably also shouldn't merge this until the |
|
I'm going to let both GCE and GKE framework accept both CSDS formats. |
|
I end up updating the GCE/GKE framework and Python tests in #27796 to support both CSDS standards. Those places should be all the CSDS use cases in grpc/grpc. |
|
Test failures look unrelated. |
copybara-service
bot
added
the
imported
Migrate deprecate `xds_config` field to `generic_xds_configs` https://www.envoyproxy.io/docs/envoy/latest/api-v3/service/status/v3/csds.proto#service-status-v3-clientconfig As per grpc/proposal#267. The c++ version is grpc/grpc#27794
As per grpc/proposal#267.