allow connectivity state watching to work on lame channels #27747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdroth
added
the
release notes: no
ctiller
approved these changes
Oct 18, 2021
copybara-service
bot
added
the
imported
ctiller
added a commit
that referenced
this pull request
Oct 19, 2021
ctiller
added a commit
that referenced
this pull request
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the internal test breakage that required the RLS LB policy to be reverted.
As an added bonus, this greatly simplifies the connectivity state watching logic.
Note: There is a behavior change here. Lame channels will now report TRANSIENT_FAILURE instead of SHUTDOWN. (I can go back to making this SHUTDOWN if we want to avoid this, but TRANSIENT_FAILURE actually seems more correct to me.)