OpenCensusCallTracer: Move context generation to StartTransportStreamOpBatch #27523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashykt
added
the
release notes: yes
markdroth
approved these changes
Oct 1, 2021
copybara-service
bot
added
the
imported
yashykt
added a commit
to yashykt/grpc
that referenced
this pull request
Oct 22, 2021
…OpBatch (grpc#27523) * OpenCensusCallTracer: Move context generation to StartTransportStreamOpBatch * Reviewer comments
yashykt
added a commit
to yashykt/grpc
that referenced
this pull request
Oct 22, 2021
…OpBatch (grpc#27523) * OpenCensusCallTracer: Move context generation to StartTransportStreamOpBatch * Reviewer comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal issue reference: b/198790188
Turns out that
StartNewAttempton the call tracer can be invoked from a different thread ,i.e., not the application thread that started the RPC. After #27221 which changed the context generation to be done on the first call to StartNewAttempt, it meant that in some cases, the context would be generated in a different thread that does not have the threadlocal tags from the original thread.