[objc] Switch to proto forward declare for gRPC codegen plugin #27444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennycd
requested review from
ctiller,
gnossen,
jtattermusch,
nicolasnoble and
veblush
as code owners
dennycd
added
lang/ObjC
platform/iOS
release notes: no
dennycd
requested review from
stanley-cheung
and removed request for
sampajano,
gnossen,
veblush,
nicolasnoble,
jtattermusch,
ctiller and
stanley-cheung
dennycd
force-pushed
the
fwd_decl_fix
branch
4 times, most recently
from
aec52d8
to
524acd0
Compare
dennycd
changed the title
sampajano
approved these changes
Sep 22, 2021
dennycd
force-pushed
the
fwd_decl_fix
branch
from
524acd0
to
fce11b6
Compare
dennycd
force-pushed
the
fwd_decl_fix
branch
from
fce11b6
to
30874cd
Compare
ctiller
added a commit
that referenced
this pull request
Sep 24, 2021
dennycd
added a commit
that referenced
this pull request
Sep 24, 2021
copybara-service
bot
added
the
imported
dennycd
added a commit
that referenced
this pull request
Sep 27, 2021
dennycd
added a commit
that referenced
this pull request
Sep 28, 2021
dennycd
added a commit
that referenced
this pull request
Sep 28, 2021
javiyt
pushed a commit
to javiyt/grpc
that referenced
this pull request
Sep 29, 2021
* Try moving promises build config out of root (grpc#27400) * Try moving promises build config out of root * buildifier * fix copyright * Revert "Try moving promises build config out of root (grpc#27400)" (grpc#27504) This reverts commit fd64bbe. * Revert "Revert "pass subchannel address separately instead of as a channel arg (grpc#27443)" (grpc#27489)" (grpc#27491) This reverts commit 20cc6e7. * Make deadline the first metadata trait (grpc#27468) * Revert deletion of api_fuzzer.cc (grpc#27424) * Revert "Delete api_fuzzer" This reverts commit 6f5b462. * Revert "Delete api_fuzzer.cc" This reverts commit ff8fecb. * fix some stuff * more fixes * more fixes * compiles * Automated change: Fix sanity tests * corpus update * fixes * Automated change: Fix sanity tests * fix illegal term * fix? * clear corpora * cleanup Co-authored-by: ctiller <ctiller@users.noreply.github.com> * Revert "Revert "[objc] Switch to forward declare proto & clean up (grpc#27444)" (grpc#27473)" (grpc#27475) This reverts commit 8a359d6. * Add alpha tests (subsetting) to xds_k8s_lb (grpc#27460) * Add compute alpha API config file * WIP * Try not to create a new job * Change from using discovery file to use version flag * Give compute_api_version a default value * Extend the timeout of xds_k8s_lb * Apply suggestions from code review Co-authored-by: Sergii Tkachenko <hi@sergii.org> Co-authored-by: Sergii Tkachenko <hi@sergii.org> * Add python_requires field to grpcio-* packages (grpc#27495) - Update the run_tests.py and distrib tests - Update the Dockerfiles * Fix local TSI impl to pass along unused bytes (grpc#27508) * try insecure creds in proxy case * revert server-side changes * fix local transport security to pass along unused bytes * fix security handshaker to check the result of TSI get_unused_bytes() * fix local TSI impl get_unused_bytes() to check its params * clang-format Co-authored-by: yihuaz <yihuaz@google.com> * fix memory leak (grpc#27510) Co-authored-by: Craig Tiller <ctiller@google.com> Co-authored-by: Mark D. Roth <roth@google.com> Co-authored-by: ctiller <ctiller@users.noreply.github.com> Co-authored-by: Denny C. Dai <dennycd@me.com> Co-authored-by: Lidi Zheng <lidiz@google.com> Co-authored-by: Sergii Tkachenko <hi@sergii.org> Co-authored-by: yihuaz <yihuaz@google.com>
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Sep 29, 2021
…pc#27444)" (grpc#27473)" (grpc#27475) This reverts commit 8a359d6.
dennycd
added
release notes: yes
ctiller
pushed a commit
that referenced
this pull request
Sep 29, 2021
javiyt
pushed a commit
to javiyt/grpc
that referenced
this pull request
Sep 30, 2021
* Rewrite memory quota management in C++ with Promises library (grpc#27327) * first pass new memory quota * forget the ee stuff - it should be a wrapper on top * beginning to finalize * compiles * basic tests pass * fixes * Automated change: Fix sanity tests * merge * Automated change: Fix sanity tests * add rebind test * flesh out the rest * Automated change: Fix sanity tests * add increase * prog * Automated change: Fix sanity tests * allow cancellation during run * fixes * clang-format * better allocation strategy * better allocation strategy * Automated change: Fix sanity tests * Update memory_quota.cc * format * better comment * remove block size - this is probably unnecessary complexity * fmt * cleanup * size_t * Automated change: Fix sanity tests * fixes * move makeslice into memoryallocator * move makeslice into memoryallocator * add container allocator, tests * Automated change: Fix sanity tests * fixes * Automated change: Fix sanity tests * add some docs * Automated change: Fix sanity tests * fix doc * comment vector * Automated change: Fix sanity tests * fixes * ditch the thread * exec_ctx integration * Automated change: Fix sanity tests * progress! * fuzzer * initial_corpora * Automated change: Fix sanity tests * bigger_objects * better-fuzzer * add stress test * Automated change: Fix sanity tests * Remove unused header * Iwyu * Automated change: Fix sanity tests * Portability fix, comment * Fix unused arg * Remove unused names * Removed unused name * Automated change: Fix sanity tests * windows * Automated change: Fix sanity tests * cleanup * fix-mac * cleanup, eliminate atomicbarrier * exclude some platforms * Automated change: Fix sanity tests Co-authored-by: ctiller <ctiller@users.noreply.github.com> * Remove channelz linkage. (grpc#27514) * Remove channelz linkage. * one more removal. * In src/core/lib/promise/detail/basic_seq.h, include cassert (grpc#27516) It is needed for assert(…). * BSD 3-Clause license lint fix (grpc#27499) * Revert "Revert "[objc] Turn on error exit in cocoapod pre-install (grpc#27474)" (grpc#27497)" (grpc#27500) This reverts commit 044253e. * Port compute_api_version to other TD implementations (grpc#27518) * Revert "[objc] Switch to forward declare proto & clean up (grpc#27444)" (grpc#27521) This reverts commit 4ad4954. * Add CRL Enabled Credentials to test folder (grpc#27436) * xds-k8s/xlang: switch to testing v1.41.x from v1.40.x (grpc#27525) * Chunked vector type (grpc#27517) * chunked vector type * Automated change: Fix sanity tests * compile fix Co-authored-by: ctiller <ctiller@users.noreply.github.com> Co-authored-by: Craig Tiller <ctiller@google.com> Co-authored-by: ctiller <ctiller@users.noreply.github.com> Co-authored-by: donnadionne <donnadionne@google.com> Co-authored-by: Ben Beasley <code@musicinmybrain.net> Co-authored-by: Denny C. Dai <dennycd@google.com> Co-authored-by: Lidi Zheng <lidiz@google.com> Co-authored-by: Denny C. Dai <dennycd@me.com> Co-authored-by: krestofur <83723727+krestofur@users.noreply.github.com> Co-authored-by: sanjaypujare <sanjaypujare@users.noreply.github.com>
dennycd
added
release notes: no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal clean up to remove direct proto header import and switch to proto forward declaration in codgen grpc service header. This prevents grpc service header from directly importing protobuf headers which should be avoid
Follow up steps to complete removal of GPB_GRPC_FORWARD_DECLARE_MESSAGE_PROTO macro in upstream callers.