Upgrade bazel to 4.2.1 (LTS), upgrade bazel toolchain to 4.1.0 #27410
Conversation
…exec_properties_dict
jtattermusch
changed the title
jtattermusch
added
release notes: yes
| @@ -87,8 +87,3 @@ build:ubsan --copt=-gmlt | |||
| # use double the default value for "moderate" and "long" timeout as sanitizer | |||
| # tests tend to be slower | |||
| build:ubsan --test_timeout=60,600,1800,3600 | |||
| # override the config-agnostic crosstool_top | |||
There was a problem hiding this comment.
note that ubsan RBE tests are now basically disabled (see b/200667821), but based on my understanding, making this change doesn't aggravate the current situation. Re-enabling ubsan can be handled separately, and this change making here won't make that harder to fix.
jtattermusch
requested review from
apolcyn,
ctiller,
gnossen,
nicolasnoble and
veblush
as code owners
|
I still need to look into the ios example test: https://source.cloud.google.com/results/invocations/d157b9b2-05a9-4ba8-aa82-b41e05048878/targets/github%2Fgrpc%2Frun_tests%2Fobjc_macos_opt_native%2Fios-buildtest-example-sample/tests |
|
Known failures: TSAN failure seems related to b/198790188 |
Looks like that got solved by upgrading rules_apple and apple_support. |
copybara-service
bot
added
the
imported
…27410) * update bazel to 4.2.1 * add bazel 4.2.1 to update_mirror.sh * regenerate dockerfiles * upgrade bazel toolchains to 4.1.0 * use create_rbe_exec_properties_dict instead of the deprecated create_exec_properties_dict * RBE ubsan doesnt require the crosstool_top hack anymore * update rules_apple and build_bazel_apple_support
| urls = [ | ||
| "https://mirror.bazel.build/github.com/bazelbuild/bazel-toolchains/archive/1.0.1.tar.gz", | ||
| "https://github.com/bazelbuild/bazel-toolchains/releases/download/1.0.1/bazel-toolchains-1.0.1.tar.gz", | ||
| "https://mirror.bazel.build/github.com/bazelbuild/bazel-toolchains/archive/4.1.0.tar.gz", |
There was a problem hiding this comment.
@jtattermusch I get WARNING: Download from https://mirror.bazel.build/github.com/bazelbuild/bazel-toolchains/archive/4.1.0.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found when using bazel to build things. Is this expected?
There was a problem hiding this comment.
grpc#27410)" This reverts commit 0042c2b.
See bazelbuild/bazel-toolchains#891 (comment) and #27410 (comment) Seems like the mirror for bazel toolchains changed the URL and they mirror downloads but not archives. This should fix any issues with missing mirror and workaround bazelbuild/bazel-toolchains#972 Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
Similar to the previously-attempted #25001, but this time upgrading to bazel LTS, which is highly desirable.
Also I think I managed to solve the UBSAN issue that was preventing us from merging #25001 (looks like UBSAN build works even without the --crosstool_top= override).
Merging this should also unblock #25318