Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement improved xDS NACK semantics #27276

Merged
merged 6 commits into from Sep 8, 2021

Conversation

markdroth
Copy link
Member

@markdroth markdroth commented Sep 7, 2021

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Sep 7, 2021
Copy link
Contributor

@donnadionne donnadionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment

test/cpp/end2end/xds_end2end_test.cc Outdated Show resolved Hide resolved
@markdroth
Copy link
Member Author

The "Artifact Build MacOS" failure looks like an infrastructure timeout.

@markdroth markdroth merged commit f3497eb into grpc:master Sep 8, 2021
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Sep 9, 2021
ashithasantosh pushed a commit to ashithasantosh/grpc that referenced this pull request Sep 10, 2021
* refactor xDS response parsing

* fix build

* implement improved xDS NACK semantics

* fix clang-tidy

* fix test
lidizheng pushed a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
* refactor xDS response parsing

* fix build

* implement improved xDS NACK semantics

* fix clang-tidy

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants