Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade third_party/protobuf to v3.17.3 #27227

Merged
merged 4 commits into from
Sep 6, 2021
Merged

Upgrade third_party/protobuf to v3.17.3 #27227

merged 4 commits into from
Sep 6, 2021

Conversation

donnadionne
Copy link
Contributor

No description provided.

@donnadionne donnadionne added lang/core release notes: yes Indicates if PR needs to be in release notes and removed lang/c++ labels Sep 2, 2021
jtattermusch
jtattermusch approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if the handwritten changes were in separate commits from the generated changes, but I went through all the changes and it's looking alright.

LGTM once all the tests pass and once the adhoc artifacts - packages - distribtest flow also passes.

@jtattermusch
Copy link
Contributor

Sanity tests failing 2021-09-02 06:35:55,980 FAILED: tools/distrib/check_upb_output.sh [ret=1, pid=361, time=102.2sec]

@jtattermusch
Copy link
Contributor

Adhoc artifacts / packages / distribtests run: https://fusion2.corp.google.com/invocations/89c1a33d-29e3-41a5-9f82-8c835dad4104/targets

@donnadionne
Copy link
Contributor Author

Sanity tests failing 2021-09-02 06:35:55,980 FAILED: tools/distrib/check_upb_output.sh [ret=1, pid=361, time=102.2sec]

This is fix by regen upb

@donnadionne
Copy link
Contributor Author

Adhoc artifacts / packages / distribtests run: https://fusion2.corp.google.com/invocations/89c1a33d-29e3-41a5-9f82-8c835dad4104/targets

linux failure seems to like a timeout

window failure also seems like a timeout:
T:\src>choco install nasm -y --limit-output

Installing the following packages:

nasm

By installing you accept licenses for the packages.

nasm not installed. An error occurred during installation:

The operation has timed out

nasm package files install completed. Performing other installation steps.

The install of nasm was NOT successful.

nasm not installed. An error occurred during installation:

The operation has timed out

Chocolatey installed 0/1 packages. 1 packages failed.

See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures

  • nasm (exited 1) - nasm not installed. An error occurred during installation:

The operation has timed out

Re-running both with new commit after sanity test fix

@donnadionne
Copy link
Contributor Author

Adhoc artifacts / packages / distribtests run: https://fusion2.corp.google.com/invocations/89c1a33d-29e3-41a5-9f82-8c835dad4104/targets

linux failure seems to like a timeout

window failure also seems like a timeout:
T:\src>choco install nasm -y --limit-output

Installing the following packages:

nasm

By installing you accept licenses for the packages.

nasm not installed. An error occurred during installation:

The operation has timed out

nasm package files install completed. Performing other installation steps.

The install of nasm was NOT successful.

nasm not installed. An error occurred during installation:

The operation has timed out

Chocolatey installed 0/1 packages. 1 packages failed.

See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures

  • nasm (exited 1) - nasm not installed. An error occurred during installation:

The operation has timed out

Re-running both with new commit after sanity test fix

Newest run: linux passes! but mac fails with timeout.

https://source.cloud.google.com/results/invocations/e59f884b-4e8a-4684-b0e1-41072f0434cd/targets/grpc%2Fcore%2Fexperimental%2Fgrpc_build_artifacts_multiplatform/log

@donnadionne
Copy link
Contributor Author

Finally all passed after rerunning: https://source.cloud.google.com/results/invocations/80ff5392-cf42-48e8-8a08-1f8714edc1e9/targets/grpc%2Fcore%2Fexperimental%2Fgrpc_build_artifacts_multiplatform/log

Build #1455 0038657

@donnadionne
Copy link
Contributor Author

Adhoc artifacts / packages / distribtests run: https://fusion2.corp.google.com/invocations/89c1a33d-29e3-41a5-9f82-8c835dad4104/targets

linux failure seems to like a timeout
window failure also seems like a timeout:
T:\src>choco install nasm -y --limit-output
Installing the following packages:
nasm
By installing you accept licenses for the packages.
nasm not installed. An error occurred during installation:
The operation has timed out
nasm package files install completed. Performing other installation steps.
The install of nasm was NOT successful.
nasm not installed. An error occurred during installation:
The operation has timed out
Chocolatey installed 0/1 packages. 1 packages failed.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Failures

  • nasm (exited 1) - nasm not installed. An error occurred during installation:

The operation has timed out
Re-running both with new commit after sanity test fix

Newest run: linux passes! but mac fails with timeout.

https://source.cloud.google.com/results/invocations/e59f884b-4e8a-4684-b0e1-41072f0434cd/targets/grpc%2Fcore%2Fexperimental%2Fgrpc_build_artifacts_multiplatform/log

Finally all passed after rerunning: https://source.cloud.google.com/results/invocations/80ff5392-cf42-48e8-8a08-1f8714edc1e9/targets/grpc%2Fcore%2Fexperimental%2Fgrpc_build_artifacts_multiplatform/log

Build #1455 0038657

@donnadionne donnadionne merged commit f9a2a74 into grpc:master Sep 6, 2021
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Sep 7, 2021
@jtattermusch jtattermusch mentioned this pull request Sep 8, 2021
Closed
lidizheng pushed a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
@donnadionne @lidizheng
Upgrade third_party/protobuf to v3.17.3 (grpc#27227)
aba6ddf 
* update protobuf dependency

* version changes and generated files

* updating upb to use the latest proto and regen files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtattermusch jtattermusch jtattermusch approved these changes

@ctiller ctiller Awaiting requested review from ctiller

@gnossen gnossen Awaiting requested review from gnossen gnossen is a code owner

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

@veblush veblush Awaiting requested review from veblush veblush is a code owner

Assignees
No one assigned
Labels
imported Specifies if the PR has been imported to the internal repository lang/core release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@donnadionne @jtattermusch