Open census call attempt span name and attribute changes (#26889) #26902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* C++ OpenCensus filter: Add attributes to per-attempt span * Reviewer comments * Reviewer comment * Remove extraneous assert
yashykt
added
release notes: yes
markdroth
approved these changes
Aug 6, 2021
|
Known issues: #26595 |
dennycd
pushed a commit
to dennycd/grpc
that referenced
this pull request
Aug 10, 2021
…grpc#26902) * C++ OpenCensus filter: Add attributes to per-attempt span * Reviewer comments * Reviewer comment * Remove extraneous assert
dennycd
pushed a commit
to dennycd/grpc
that referenced
this pull request
Aug 11, 2021
…grpc#26902) * C++ OpenCensus filter: Add attributes to per-attempt span * Reviewer comments * Reviewer comment * Remove extraneous assert
dennycd
pushed a commit
to dennycd/grpc
that referenced
this pull request
Aug 11, 2021
…grpc#26902) * C++ OpenCensus filter: Add attributes to per-attempt span * Reviewer comments * Reviewer comment * Remove extraneous assert
Vignesh2208
pushed a commit
to Vignesh2208/grpc
that referenced
this pull request
Aug 20, 2021
…grpc#26902) * C++ OpenCensus filter: Add attributes to per-attempt span * Reviewer comments * Reviewer comment * Remove extraneous assert
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
…grpc#26902) * C++ OpenCensus filter: Add attributes to per-attempt span * Reviewer comments * Reviewer comment * Remove extraneous assert
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
…grpc#26902) * C++ OpenCensus filter: Add attributes to per-attempt span * Reviewer comments * Reviewer comment * Remove extraneous assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26889 to v1.40.x
C++ OpenCensus filter: Add attributes to per-attempt span
Reviewer comments
Reviewer comment
Remove extraneous assert