-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate copied Content native lib items with package id to enable customization #26725
Conversation
…stomization Add `%(NuGetPackageId)` as is standard procedure for nuget package-provided assets, so that other MSBuild targets can act on items contributed by Grpc.Core as needed, for example, in Pack scenarios. Fixes grpc#26724
|
Adhoc distribtest run: https://fusion2.corp.google.com/invocations/093ac219-c739-419b-a917-0bf58ffd86c9/targets macos artifact build consistently hits infrastructure problems (the build is timing out), so I'm unable to get a green build. That problem is orthogonal to this PR, so I'm simply going to merge and check the greenness of distribtests on the continous run afterwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the tests pass.
@apolcyn please add another LGTM. |
FTR I checked the distribtests results after merging and they were green. |
…stomization (grpc#26725) Add `%(NuGetPackageId)` as is standard procedure for nuget package-provided assets, so that other MSBuild targets can act on items contributed by Grpc.Core as needed, for example, in Pack scenarios. Fixes grpc#26724
Add
%(NuGetPackageId)
as is standard procedure for nuget package-provided assets,so that other MSBuild targets can act on items contributed by Grpc.Core as needed, for
example, in Pack scenarios.
Fixes #26724
@nicolasnoble