Remove fault injection environmental variable guard #25792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidizheng
added
lang/c++
release notes: yes
markdroth
requested changes
Mar 23, 2021
There was a problem hiding this comment.
Looks like you're removing one test case that actually needs to stick around. Otherwise, this looks great!
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lidizheng)
test/cpp/end2end/xds_end2end_test.cc, line 3491 at r1 (raw file):
// Test that we NACK filters without configs. TEST_P(LdsTest, RejectsHttpFilterWithoutConfig) {
Why is this test being removed? I think we still need this.
markdroth
approved these changes
Mar 23, 2021
There was a problem hiding this comment.
Looks great!
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lidizheng)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Also remove some env-related test cases.
This change is