Update protobuf to 3.9.0

[TeBoring]

No description provided.

[thelinuxfoundation]

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

• User @TeBoring isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

[jtattermusch]

It is useful to provide link to the last update #19182 - most changes should be of the same nature.

[jtattermusch]

This is mostly looking good (with exception of my comment). Let's see what the tests say.

[jtattermusch]

I think the missing .0 is intended. (see PR for bump to 3.8). Please fix in the .template file

[jtattermusch]

@TeBoring for some reason the CLA check is failing - can you doublecheck please?

[TeBoring]

What do I need to do for the CLA? Can we sign the cla for the foundation?

…

On Wed, Jul 17, 2019 at 07:36 Jan Tattermusch ***@***.***> wrote: @TeBoring <https://github.com/TeBoring> for some reason the CLA check is failing - can you doublecheck please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19630?email_source=notifications&email_token=ABHUPZP2RJMNA36D6KJCUBDP74VAFA5CNFSM4ICNRII2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ENBSI#issuecomment-512282825>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHUPZO3C5I2HTLB5XYQB2LP74VAFANCNFSM4ICNRIIQ> .

[jtattermusch]

CLA: https://identity.linuxfoundation.org/projects/cncf you should be able to sign as google employee.

[jtattermusch]

The c# error is something we need to take a look into. It might also be that 3.9.0 might contain a breaking change that needs to be rolled back.

  Grpc.Microbenchmarks -> /var/local/git/grpc/src/csharp/Grpc.Microbenchmarks/bin/Debug/net461/Grpc.Microbenchmarks.exe
Math.cs(39,17): error CS1729: 'GeneratedClrTypeInfo' does not contain a constructor that takes 7 arguments [/var/local/git/grpc/src/csharp/Grpc.Examples/Grpc.Examples.csproj]
Math.cs(40,17): error CS1729: 'GeneratedClrTypeInfo' does not contain a constructor that takes 7 arguments [/var/local/git/grpc/src/csharp/Grpc.Examples/Grpc.Examples.csproj]
Math.cs(41,17): error CS1729: 'GeneratedClrTypeInfo' does not contain a constructor that takes 7 arguments [/var/local/git/grpc/src/csharp/Grpc.Examples/Grpc.Examples.csproj]
Math.cs(42,17): error CS1729: 'GeneratedClrTypeInfo' does not contain a constructor that takes 7 arguments [/var/local/git/grpc/src/csharp/Grpc.Examples/Grpc.Examples.csproj]
Math.cs(43,17): error CS1729: 'GeneratedClrTypeInfo' does not contain a constructor that takes 7 arguments [/var/local/git/grpc/src/csharp/Grpc.Examples/Grpc.Examples.csproj]

Other problems:
https://source.cloud.google.com/results/invocations/c03ae785-c291-4a23-95a9-c0b8a91decf6/targets/github%2Fgrpc%2Fsanity_linux_dbg_native/tests

[jtattermusch]

The C# problem likely has to do with this change:
protocolbuffers/protobuf@9e89b6e#diff-a11488f894c3a2f0a362c3ea33941a88R107

[jtattermusch]

CC @ObsidianMinor (probably related to protocolbuffers/protobuf#5350)

[TeBoring]

I signed

[ObsidianMinor]

3.9.0 was delisted until a 3.9.1 release can be made to with these changes. The C# issues are probably related to that.

[anandolee]

Looks like the test is using new protoc but old c# runtime? @jtattermusch is the failure in this case, and why old c# runtime is used in Grpc's test?

Protobuf only gurantee old generated code work with new runtime. Not gurantee new generated code work with old runtime

[jtattermusch]

Ok, I think I now understand what happened:

• this PR attempts to increase C# protobuf runtime version in Version.csproj.include, but it turns out that's a dead copy that doesn't influence anything, so the protobuf runtime is not really updated, but the code is regenerated. That explains the C# build error.

I created #19679 to fix the problem. After it's merged, this PR needs to be updated to modify src/csharp/build/dependencies.props instead of Version.csproj.include

[jtattermusch]

Superseded by #19867