Change size_t to socklen_t in resolve_address #14464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
|
1 similar comment
|
|
1 similar comment
|
|
|
|
2 similar comments
|
|
|
|
|
|
Has the reporter of #13458 confirmed that this branch works? Also, do we have any measure in place to prevent the reoccurrence of this problem in the future? |
|
@vjpai The reporter referenced to #11390 which has gone stale as a solution that worked for big endian systems. This pull request just adds on changes to make sure that the changes also work for other platforms. As for a measure in place to prevent the recurrence of problem, I think once we remove the usage of reinterpret_cast in our code (or only use it when absolutely necessary), we won't see this anymore. |
|
Ah, so little endian-ness masks the size difference issue in some cases since socklen_t typically has small values. |
|
Talked to Nico offline. We don't have the capability to add big endian systems to our test infrastructure currently. Kokoro doesn't support it. |
|
|
|
|
|
|
vjpai
approved these changes
Mar 15, 2018
|
@dgquintas @markdroth @a11r Need an approval from a code owner :) |
|
|
markdroth
approved these changes
Mar 16, 2018
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the issue mentioned in #13458
On big endian systems with different sizes for size_t and socklen_t, we will end up with a wrong address length currently.