[build] Stop publishing iomgr/error.h from grpc_base #31521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctiller
added
the
release notes: no
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
ralphchung
reviewed
Nov 2, 2022
| @@ -1108,6 +1109,7 @@ grpc_cc_library( | |||
| "absl/status", | |||
| "absl/strings:str_format", | |||
| ], | |||
| visibility = ["@grpc:alt_grpc_base_legacy"], | |||
There was a problem hiding this comment.
Just curious about the meaning of this?
There was a problem hiding this comment.
Means that things that can see grpc_base can see this target too... which for now is approximately what we want.
ralphchung
approved these changes
Nov 2, 2022
copybara-service
bot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking the strategy of knocking out one of these TODOs at a time until they're gone, as prework for landing #31500