Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously trying to define this macro through an env var, which actually only affects the
make
invocation that extconf.rb uses to build the grpc core library on non-windows platforms.Note that all of the other
CPPFLAGS
set through env vars are targeting the grpc core library, rather than the ruby C-extension code, so it worked. But this new macro for windows ucrt is targeting the ruby C-extension code, so it looks like it needs to be set via $CFLAGS.Should fix #30933
cc @johnnyshields