Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB policies with multiple active children should delay picker updates while updating children #28984

Closed
ejona86 opened this issue Feb 28, 2022 · 1 comment · Fixed by #29252 or #29350
Closed

Comments

@ejona86
Copy link
Member

ejona86 commented Feb 28, 2022

To allow localities moving priorities within xDS atomically, when processing a config update, the priority policy should inhibit upward picker updates of its own until it has provided the configs to all of its children. Children update their picker synchronously when receiving the config update, so after passing down the new configuration to all children the priority policy will have updated pickers for each and should at that point propagate its own picker update upward. This was decided in the cross-language TL discussion on 2022-02-11.

Java and Go will need to validate that all policies update their picker synchronously when receiving a config update, but this is the case already for C.

grpc/grpc-java#8952 grpc/grpc-go#5211

@markdroth markdroth changed the title Priority policy should delay picker updates while updating children LB policies with multiple active children should delay picker updates while updating children Apr 7, 2022
@markdroth
Copy link
Member

Also done for weighted_target and xds_cluster_manager in #29313.

Still need this for RLS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment