Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority policy should delay picker updates while updating children #8952

Closed
ejona86 opened this issue Feb 28, 2022 · 4 comments
Closed

Priority policy should delay picker updates while updating children #8952

ejona86 opened this issue Feb 28, 2022 · 4 comments
Assignees
Milestone

Comments

@ejona86
Copy link
Member

ejona86 commented Feb 28, 2022

To allow localities moving priorities within xDS atomically, when processing a config update, the priority policy should inhibit upward picker updates of its own until it has provided the configs to all of its children. Children update their picker synchronously when receiving the config update, so after passing down the new configuration to all children the priority policy will have updated pickers for each and should at that point propagate its own picker update upward. This was decided in the cross-language TL discussion on 2022-02-11.

We need to audit the code to ensure existing LBs update their picker synchronously, and tweak the docs. I expect all LBs are already doing this, but it is worth the check.

grpc/grpc#28984 grpc/grpc-go#5211

@markdroth
Copy link
Member

We've realized that we also need to do this for the xds_cluster_manager and weighted_target policies.

(Basically, our rule should be that we do this for any policy that has multiple active children at the same time.)

@markdroth
Copy link
Member

Need this in the rls policy too.

@ejona86
Copy link
Member Author

ejona86 commented Apr 7, 2022

CC @YifeiZhuang

@YifeiZhuang YifeiZhuang pinned this issue Apr 12, 2022
@ejona86 ejona86 unpinned this issue Apr 12, 2022
@ejona86 ejona86 pinned this issue Apr 12, 2022
@ejona86 ejona86 unpinned this issue Apr 12, 2022
@temawi
Copy link
Contributor

temawi commented Sep 14, 2022

priority: #9363
weighted_target: #9306
cluster_manager: #9365

We determined that, in Java at least, RLS did not need this change.

@temawi temawi closed this as completed Sep 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
@ejona86 ejona86 modified the milestones: Next, 1.49 Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants