Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Java S2A protos #149

Merged
merged 3 commits into from
Apr 29, 2024
Merged

gRPC Java S2A protos #149

merged 3 commits into from
Apr 29, 2024

Conversation

rmehta19
Copy link
Contributor

@rmehta19 rmehta19 commented Apr 18, 2024

Copy link

linux-foundation-easycla bot commented Apr 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@matthewstevenson88
Copy link
Contributor

Thanks for the PR! This change LGTM. Please fix the CLA issue, remove the "draft" piece from the title, and in the PR description can we link to https://github.com/google/s2a-go/blob/main/README.md ?

@rmehta19 rmehta19 changed the title [DRAFT] gRPC Java S2A protos gRPC Java S2A protos Apr 19, 2024
@rmehta19
Copy link
Contributor Author

@matthewstevenson88 Thanks for the review! Done.

@matthewstevenson88
Copy link
Contributor

LGTM.

Please get approval from @ejona86 as well. (I think I technically have the permission to approve this, but I'm not one of the normal maintainers of this repo so I'd like to get Eric's sign-off that he is OK with where we put the protos.)

grpc/gcp/s2a/common.proto Outdated Show resolved Hide resolved
grpc/gcp/s2a/common.proto Outdated Show resolved Hide resolved
@ejona86 ejona86 merged commit 1dc480d into grpc:master Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants