Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pick-first-load-balancer pick subchannel lost state listener #2559

Merged
merged 1 commit into from Aug 29, 2023

Conversation

gusumuzhe
Copy link
Contributor

If subchannel wrap isn't equals and wrap's real subchannel is same, will result subchannel‘s state listener loss. When grpc server down, pick first can't change connectivity state to TRANSIENT_FAILURE, and load-balancing-call doPick function will infinite call.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 29, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gusumuzhe / name: Chao Zhang (613c914)

@murgatroid99 murgatroid99 changed the base branch from master to @grpc/grpc-js@1.9.x August 29, 2023 17:05
@murgatroid99 murgatroid99 changed the base branch from @grpc/grpc-js@1.9.x to master August 29, 2023 17:05
Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@murgatroid99 murgatroid99 merged commit 8d532f9 into grpc:master Aug 29, 2023
9 of 10 checks passed
@murgatroid99
Copy link
Member

This has been published in version 1.9.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants