New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc-js-xds: Use distroless Node image for interop Dockerfile #2477
grpc-js-xds: Use distroless Node image for interop Dockerfile #2477
Conversation
This reduced the number of vulnerabilities from 27 to 9. All low severity without fixes. Recent master build, This PR build, I call it a win. |
Failed with
😦 |
@@ -27,7 +27,7 @@ RUN npm install | |||
WORKDIR /node/src/grpc-node/packages/grpc-js-xds | |||
RUN npm install | |||
|
|||
FROM node:18-slim | |||
FROM gcr.io/distroless/nodejs18-debian11:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it expects /nodejs/bin/node
instead of node
in ENTRYPOINT: https://github.com/GoogleContainerTools/distroless/blob/main/nodejs/BUILD#L38
Re-running the tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed test suites: 0
Switching to distroless to minimize exposure to vulnerabilities.