Import examples from core repository #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murgatroid99
force-pushed
the
import_examples
branch
from
279de4e
to
204cd38
Compare
sergiitk
approved these changes
Jun 22, 2023
murgatroid99
added a commit
to grpc/grpc
that referenced
this pull request
Jun 23, 2023
…tion (#33522) This change is part of a migration of the Node examples from this repository to the grpc/grpc-node repository, along with grpc/grpc-node#2474. I replaced the files with references to the new location instead of deleting them so that people following links in existing external resources would find information about the new location instead of an unhelpful 404 error. I discovered that even some of the individual `.js` files are linked from other places, so to be safe I performed this replacement on every file in the directory.
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 13, 2023
…tion (grpc#33522) This change is part of a migration of the Node examples from this repository to the grpc/grpc-node repository, along with grpc/grpc-node#2474. I replaced the files with references to the new location instead of deleting them so that people following links in existing external resources would find information about the new location instead of an unhelpful 404 error. I discovered that even some of the individual `.js` files are linked from other places, so to be safe I performed this replacement on every file in the directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new push to expand our examples significantly, I think it makes more sense for the examples to be here in the same repository as the code than for them to be in the core repository.
This is roughly a copy of the core repository's examples/node directory, with a few changes:
package.jsonfile into the main one.This change will be made along with a change to the core repository replacing the examples there with links to this directory, and a change to the grpc.io repository updating references to these examples.