Convert to eslint/prettier #2465
Conversation
Moving from exporting a namespace to just putting assert2 functions into their own files Fixes grpc#2464
GTS provides config for ESLint, Prettier and TSConfig; this commit removes GTS, but brings over the configuration details Fixes grpc#2464
…fig settings This might actually be unnecessary; since I've copied over configuration settings from the GTS package, I figured I'd add this notice. It's in a file, since there's no capacity for adding comments in a JSON or .rc file. It feels doubtful that configuration settings fall under the auspices of the Apache License, but I'll leave that to the maintainers to decide.
|
I'm happy to just change grpc-js for now. Did you need to make any manual changes to make the code conform to the lint rules? |
|
FYI the Windows Test failure is not a concern here. It is a previously known failure unrelated to this change. |
| @@ -16,7 +16,7 @@ | |||
| */ | |||
|
|
|||
| import * as loader from '@grpc/proto-loader'; | |||
| import * as assert from 'assert'; | |||
| import * as assert2 from './assert2'; | |||
There was a problem hiding this comment.
@murgatroid99 this is one material change I made (although it's really just a simple refactor).
It just removes the exporting of a namespace.
| } catch (err) { | ||
| throw err; | ||
| } | ||
| const metadata: Metadata = await callCredentials.generateMetadata({ |
There was a problem hiding this comment.
@murgatroid99 this is another material change; I removed the redundant try/catch (since the catch block just rethrows the caught error).
This was causing a lint error and seems redundant anyway.
| @@ -147,12 +138,10 @@ describe('CallCredentials', () => { | |||
| await Promise.all( | |||
| testCases.map(async testCase => { | |||
| const { credentials, expected } = testCase; | |||
| let metadata: Metadata; | |||
| try { | |||
There was a problem hiding this comment.
@murgatroid99 this is another material change; I removed the redundant try/catch (since the catch block just rethrows the caught error).
This was causing a lint error and seems redundant anyway.
| @@ -0,0 +1,4 @@ | |||
| The following files contain configuration settings that were derived from [the this commit](https://github.com/google/gts/commit/3b9ab6dd59691f77f5c5c632a44c6762ba4ef7c6) in the Google GTS repository: | |||
There was a problem hiding this comment.
@murgatroid99 is this helpful, necessary, overkill? 🤷
There was a problem hiding this comment.
I don't know if it's necessary, but I have no objection to including it.
This change is limited to
grpc-jsfor now for a few reasons:If you'd prefer to have every package updated, I'd suggest either: