grpc-js-xds: Implement federation support #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Third time's the charm |
|
Another URL map test job run: |
sergiitk
reviewed
Jun 21, 2023
gnossen
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements federation as described in gRFC A47. It also implements the XdsClient Generic API because that simplified the adaptation of the core's XdsClient architecture for federation to Node.
Note regarding the Server Channel Map section: I implemented this as though connections will be torn down by the idle timeout. This is not currently the case, but I plan to implement that before releasing this feature.
Future work: expand the test control plane server (
test/xds-server.ts) to request and report LRS information in order to test that clients that use different authorities send their load reports to the right place.