Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-js-xds: Enable outlier detection by default #2221

Merged
merged 2 commits into from Sep 7, 2022
Merged

grpc-js-xds: Enable outlier detection by default #2221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8022a5
grpc-js-xds: Enable outlier detection by default
murgatroid99 Sep 7, 2022
3c27ed4
grpc-js: Update grpc-js outlier detection check to match xds check
murgatroid99 Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/grpc-js-xds/src/environment.ts
View file
Open in desktop
Expand Up @@ -16,4 +16,4 @@
*/

export const EXPERIMENTAL_FAULT_INJECTION = (process.env.GRPC_XDS_EXPERIMENTAL_FAULT_INJECTION ?? 'true') === 'true';
export const EXPERIMENTAL_OUTLIER_DETECTION = process.env.GRPC_EXPERIMENTAL_ENABLE_OUTLIER_DETECTION === 'true';
export const EXPERIMENTAL_OUTLIER_DETECTION = (process.env.GRPC_EXPERIMENTAL_ENABLE_OUTLIER_DETECTION ?? 'true') === 'true';
2 changes: 1 addition & 1 deletion packages/grpc-js/src/load-balancer-outlier-detection.ts
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@ function trace(text: string): void {

const TYPE_NAME = 'outlier_detection';

const OUTLIER_DETECTION_ENABLED = process.env.GRPC_EXPERIMENTAL_ENABLE_OUTLIER_DETECTION !== 'false';
const OUTLIER_DETECTION_ENABLED = (process.env.GRPC_EXPERIMENTAL_ENABLE_OUTLIER_DETECTION ?? 'true') === 'true';

export interface SuccessRateEjectionConfig {
readonly stdev_factor: number;
Expand Down