Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set defaults to false for loader definitions #1867

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set defaults to false for loader definitions #1867

wants to merge 1 commit into from

Commits on Jul 30, 2021

  1. Set defaults to false for loader definitions 

    There isn't much value in having defaults set for descriptors

What's more it causes issues when using those descriptors with protobufjs

Descriptors with oneofIndex: 0, cause issues when they aren't part of a oneof
    @RichieAHB
    RichieAHB committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    8968bf8 View commit details
    Browse the repository at this point in the history