Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-js: Remove explicit version compatibility check #1739

Merged
merged 1 commit into from Apr 6, 2021
Merged

grpc-js: Remove explicit version compatibility check #1739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/grpc-js/package.json
View file
Open in desktop
Expand Up @@ -22,7 +22,6 @@
"@types/mocha": "^5.2.6",
"@types/ncp": "^2.0.1",
"@types/pify": "^3.0.2",
"@types/semver": "^6.0.1",
"@types/yargs": "^15.0.5",
"clang-format": "^1.0.55",
"execa": "^2.0.3",
Expand Down Expand Up @@ -57,8 +56,7 @@
"posttest": "npm run check"
},
"dependencies": {
"@types/node": ">=12.12.47",
"semver": "^6.2.0"
"@types/node": ">=12.12.47"
},
"files": [
"src/**/*.ts",
Expand Down
7 changes: 0 additions & 7 deletions packages/grpc-js/src/index.ts
View file
Open in desktop
Expand Up @@ -15,8 +15,6 @@
*
*/

import * as semver from 'semver';

import {
ClientDuplexStream,
ClientReadableStream,
Expand Down Expand Up @@ -66,11 +64,6 @@ import {
ServerDuplexStream,
} from './server-call';

const supportedNodeVersions = require('../../package.json').engines.node;
if (!semver.satisfies(process.version, supportedNodeVersions)) {
throw new Error(`@grpc/grpc-js only works on Node ${supportedNodeVersions}`);
}

export { OAuth2Client };

/**** Client Credentials ****/
Expand Down