Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClientOptions types #1559

Merged

Commits on Sep 1, 2020

  1. Fix ClientOptions types

    Remove index signature from ChannelOptions to fix intersection error
    described in grpc#1558 which causes issues on using ClientOptions direct
    fields with TypeScript.
    
    Removing of index signature required few minor changes:
     - adding few constant types that were used throughout the app
     - using `as const` assertion in xds-client
     - using not-so-great type cast in channelOptionsEqual
    
    Alternative solution would be removing the index signature from
    ChannelOptions explicitly in ClientOptions definition, which is not
    trivial and probably calls for a generic type helper.
    
    See: grpc#1558
    Fixes: grpc#1558
    smolijar committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    b2d8982 View commit details
    Browse the repository at this point in the history