Fix ClientOptions types #1559
Merged
Fix ClientOptions types #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I think the correct solution here is actually to just make the index signature have the value type |
smolijar
force-pushed
the
fix/1558-broken-client-option-types
branch
from
3301e60
to
56241fe
Compare
Remove index signature from ChannelOptions to fix intersection error described in grpc#1558 which causes issues on using ClientOptions direct fields with TypeScript. Removing of index signature required few minor changes: - adding few constant types that were used throughout the app - using `as const` assertion in xds-client - using not-so-great type cast in channelOptionsEqual Alternative solution would be removing the index signature from ChannelOptions explicitly in ClientOptions definition, which is not trivial and probably calls for a generic type helper. See: grpc#1558 Fixes: grpc#1558
smolijar
force-pushed
the
fix/1558-broken-client-option-types
branch
from
56241fe
to
b2d8982
Compare
|
@murgatroid99 Thank you for feedback, I am not too familiar with the codebase. I added the index any signature and removed the type obscurities derived from the previous solution. I justk kept the addition of previously added keys apart from that, which are used throughout the codebase. |
murgatroid99
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove index signature from ChannelOptions to fix intersection error
described in #1558 which causes issues on using ClientOptions direct
fields with TypeScript.
Removing of index signature required few minor changes:
as constassertion in xds-clientAlternative solution would be removing the index signature from
ChannelOptions explicitly in ClientOptions definition, which is not
trivial and probably calls for a generic type helper.
See: #1558
Fixes: 1558