Merge pull request #1665 from murgatroid99/grpc-js_round_robin_rereso…

…lve_fix grpc-js: round robin: re-resolve when subchannels go idle
grpc · Jan 20, 2021 · c328ba7 · c328ba7
2 parents 0b026be + 36986f6
commit c328ba7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/grpc-js/package.json b/packages/grpc-js/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@grpc/grpc-js",
-  "version": "1.2.3",
+  "version": "1.2.4",
   "description": "gRPC Library for Node - pure JS implementation",
   "homepage": "https://grpc.io/",
   "repository": "https://github.com/grpc/grpc-node/tree/master/packages/grpc-js",

diff --git a/packages/grpc-js/src/load-balancer-round-robin.ts b/packages/grpc-js/src/load-balancer-round-robin.ts
@@ -128,14 +128,12 @@ export class RoundRobinLoadBalancer implements LoadBalancer {
       this.subchannelStateCounts[previousState] -= 1;
       this.subchannelStateCounts[newState] += 1;
       this.calculateAndUpdateState();
-
-      if (newState === ConnectivityState.TRANSIENT_FAILURE) {
-        this.channelControlHelper.requestReresolution();
-      }
+
       if (
         newState === ConnectivityState.TRANSIENT_FAILURE ||
         newState === ConnectivityState.IDLE
       ) {
+        this.channelControlHelper.requestReresolution();
         subchannel.startConnecting();
       }
     };