Merge pull request #2188 from murgatroid99/grpc-js_ping_error_check

grpc-js: Handle errors when trying to ping
grpc · Aug 8, 2022 · b08171e · b08171e
2 parents fb8de85 + 31d28b5
commit b08171e
Showing 1 changed file with 15 additions and 6 deletions.
diff --git a/packages/grpc-js/src/subchannel.ts b/packages/grpc-js/src/subchannel.ts
@@ -361,12 +361,21 @@ export class Subchannel {
       this.handleDisconnect();
     }, this.keepaliveTimeoutMs);
     this.keepaliveTimeoutId.unref?.();
-    this.session!.ping(
-      (err: Error | null, duration: number, payload: Buffer) => {
-        this.keepaliveTrace('Received ping response');
-        clearTimeout(this.keepaliveTimeoutId);
-      }
-    );
+    try {
+      this.session!.ping(
+        (err: Error | null, duration: number, payload: Buffer) => {
+          this.keepaliveTrace('Received ping response');
+          clearTimeout(this.keepaliveTimeoutId);
+        }
+      );
+    } catch (e) {
+      /* If we fail to send a ping, the connection is no longer functional, so
+       * we should discard it. */
+      this.transitionToState(
+        [ConnectivityState.READY],
+        ConnectivityState.TRANSIENT_FAILURE
+      );
+    }
   }
 
   private startKeepalivePings() {