Merge pull request #2663 from Ileriayo/fix-deprecation-node-example

Fix deprecated code
grpc · Feb 12, 2024 · 5e2fa71 · 5e2fa71
2 parents 5b44a44 + 76717f8
commit 5e2fa71
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 8 deletions.
diff --git a/examples/deadline/server.js b/examples/deadline/server.js
@@ -100,8 +100,11 @@ function main() {
   });
   const server = new grpc.Server();
   server.addService(echoProto.Echo.service, serviceImplementation);
-  server.bindAsync(`0.0.0.0:${argv.port}`, grpc.ServerCredentials.createInsecure(), () => {
-    server.start();
+  server.bindAsync(`0.0.0.0:${argv.port}`, grpc.ServerCredentials.createInsecure(), (err, port) => {
+    if (err != null) {
+      return console.error(err);
+    }
+    console.log(`gRPC listening on ${port}`)
   });
   client = new echoProto.Echo(`localhost:${argv.port}`, grpc.credentials.createInsecure());
 }

diff --git a/examples/helloworld/dynamic_codegen/greeter_server.js b/examples/helloworld/dynamic_codegen/greeter_server.js
@@ -44,8 +44,11 @@ function sayHello(call, callback) {
 function main() {
   var server = new grpc.Server();
   server.addService(hello_proto.Greeter.service, {sayHello: sayHello});
-  server.bindAsync('0.0.0.0:50051', grpc.ServerCredentials.createInsecure(), () => {
-    server.start();
+  server.bindAsync('0.0.0.0:50051', grpc.ServerCredentials.createInsecure(), (err, port) => {
+    if (err != null) {
+      return console.error(err);
+    }
+    console.log(`gRPC listening on ${port}`)
   });
 }
 

diff --git a/examples/helloworld/static_codegen/greeter_server.js b/examples/helloworld/static_codegen/greeter_server.js
@@ -37,8 +37,11 @@ function sayHello(call, callback) {
 function main() {
   var server = new grpc.Server();
   server.addService(services.GreeterService, {sayHello: sayHello});
-  server.bindAsync('0.0.0.0:50051', grpc.ServerCredentials.createInsecure(), () => {
-    server.start();
+  server.bindAsync('0.0.0.0:50051', grpc.ServerCredentials.createInsecure(), (err, port) => {
+    if (err != null) {
+      return console.error(err);
+    }
+    console.log(`gRPC listening on ${port}`)
   });
 }
 

diff --git a/examples/metadata/server.js b/examples/metadata/server.js
@@ -18,6 +18,7 @@
 
 const grpc = require('@grpc/grpc-js');
 const protoLoader = require('@grpc/proto-loader');
+const parseArgs = require('minimist');
 
 const PROTO_PATH = __dirname + '/../protos/echo.proto';
 
@@ -148,8 +149,11 @@ function main() {
   });
   const server = new grpc.Server();
   server.addService(echoProto.Echo.service, serviceImplementation);
-  server.bindAsync(`0.0.0.0:${argv.port}`, grpc.ServerCredentials.createInsecure(), () => {
-    server.start();
+  server.bindAsync(`0.0.0.0:${argv.port}`, grpc.ServerCredentials.createInsecure(), (err, port) => {
+    if (err != null) {
+      return console.error(err);
+    }
+    console.log(`gRPC listening on ${port}`)
   });
 }