Merge pull request #2173 from murgatroid99/grpc-js_outlier_detection_…

…stdev_fix grpc-js: Outlier detection: Fix standard deviation calculation
grpc · Jul 22, 2022 · 586f7c6 · 586f7c6
2 parents 6bf3122 + fbf7944
commit 586f7c6
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/grpc-js/src/load-balancer-outlier-detection.ts b/packages/grpc-js/src/load-balancer-outlier-detection.ts
@@ -430,11 +430,12 @@ export class OutlierDetectionLoadBalancer implements LoadBalancer {
 
     // Step 2
     const successRateMean = successRates.reduce((a, b) => a + b) / successRates.length;
-    let successRateVariance = 0;
+    let successRateDeviationSum = 0;
     for (const rate of successRates) {
       const deviation = rate - successRateMean;
-      successRateVariance += deviation * deviation;
+      successRateDeviationSum += deviation * deviation;
     }
+    const successRateVariance = successRateDeviationSum / successRates.length;
     const successRateStdev = Math.sqrt(successRateVariance);
     const ejectionThreshold = successRateMean - successRateStdev * (successRateConfig.stdev_factor / 1000);