Merge pull request #2204 from murgatroid99/grpc-js_outlier_detection_…

…failure_percentage_fix grpc-js: Outlier Detection: fix failure percentage min hosts check
grpc · Aug 24, 2022 · 1b2cf99 · 1b2cf99
2 parents 3db72f9 + 8664c83
commit 1b2cf99
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/packages/grpc-js/src/load-balancer-outlier-detection.ts b/packages/grpc-js/src/load-balancer-outlier-detection.ts
@@ -500,7 +500,15 @@ export class OutlierDetectionLoadBalancer implements LoadBalancer {
     }
     trace('Running failure percentage check. threshold=' + failurePercentageConfig.threshold + ' request volume threshold=' + failurePercentageConfig.request_volume);
     // Step 1
-    if (this.addressMap.size < failurePercentageConfig.minimum_hosts) {
+    let addressesWithTargetVolume = 0;
+    for (const mapEntry of this.addressMap.values()) {
+      const successes = mapEntry.counter.getLastSuccesses();
+      const failures = mapEntry.counter.getLastFailures();
+      if (successes + failures >= failurePercentageConfig.request_volume) {
+        addressesWithTargetVolume += 1;
+      }
+    }
+    if (addressesWithTargetVolume < failurePercentageConfig.minimum_hosts) {
       return;
     }