Merge pull request #2100 from murgatroid99/grpc-js_dns_resolver_doubl…

…e_call grpc-js: Fix double resolver calls in DNS resolver
grpc · Apr 20, 2022 · 0a9cf38 · 0a9cf38
2 parents 028047f + 964c7a6
commit 0a9cf38
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/grpc-js/src/backoff-timeout.ts b/packages/grpc-js/src/backoff-timeout.ts
@@ -100,6 +100,7 @@ export class BackoffTimeout {
   }
 
   private runTimer(delay: number) {
+    clearTimeout(this.timerId);
     this.timerId = setTimeout(() => {
       this.callback();
       this.running = false;

diff --git a/packages/grpc-js/src/resolver-dns.ts b/packages/grpc-js/src/resolver-dns.ts
@@ -158,7 +158,6 @@ class DnsResolver implements Resolver {
     if (this.ipResult !== null) {
       trace('Returning IP address for target ' + uriToString(this.target));
       setImmediate(() => {
-        this.backoff.reset();
         this.listener.onSuccessfulResolution(
           this.ipResult!,
           null,
@@ -167,6 +166,8 @@ class DnsResolver implements Resolver {
           {}
         );
       });
+      this.backoff.stop();
+      this.backoff.reset();
       return;
     }
     if (this.dnsHostname === null) {
@@ -178,7 +179,11 @@ class DnsResolver implements Resolver {
           metadata: new Metadata(),
         });
       });
+      this.stopNextResolutionTimer();
     } else {
+      if (this.pendingLookupPromise !== null) {
+        return;
+      }
       trace('Looking up DNS hostname ' + this.dnsHostname);
       /* We clear out latestLookupResult here to ensure that it contains the
        * latest result since the last time we started resolving. That way, the
@@ -299,6 +304,7 @@ class DnsResolver implements Resolver {
   }
 
   private startNextResolutionTimer() {
+    clearTimeout(this.nextResolutionTimer);
     this.nextResolutionTimer = setTimeout(() => {
       this.stopNextResolutionTimer();
       if (this.continueResolving) {
@@ -314,10 +320,12 @@ class DnsResolver implements Resolver {
   }
 
   private startResolutionWithBackoff() {
+    if (this.pendingLookupPromise === null) {
       this.continueResolving = false;
       this.startResolution();
       this.backoff.runOnce();
       this.startNextResolutionTimer();
+    }
   }
 
   updateResolution() {