Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use real objects instead of mocks. #9523

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Use real objects instead of mocks. #9523

merged 3 commits into from
Sep 7, 2022

Commits on Sep 7, 2022

  1. Use real objects instead of mocks. 

    My motivation for making this change is that [`ByteBuffer` is becoming
`sealed`](https://download.java.net/java/early_access/loom/docs/api/java.base/java/nio/ByteBuffer.html)
in new versions of Java. This makes it impossible for Mockito's
_current_ default mockmaker to mock it.

That said, Mockito will likely [switch its default
mockmaker](mockito/mockito#2589) to an
alternative that _is_ able to mock `sealed` classes. However, there are
downside to that, such as [slower
performance](mockito/mockito#2589 (comment)),
so it's probably better to leave our options open by avoiding mocking at
all.

And in this case, it's equally easy to use real objects.

As a bonus, I think that real objects makes the code a little easier to
follow: Before, we created mocks that the code under test never
interacted with in any way. (The code just passed them through to a
delegate.) When I first read the tests, I was confused, since I assumed
that the mock we were creating was the same mock that we then passed to
`verify` at the end of the method. That turned out not to be the case.

Given that, I figured I'd switch not only to a real `ByteBuffer` but
also to a real `OutputStream`.
    @cpovirk
    cpovirk committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2459bac View commit details
    Browse the repository at this point in the history

  2. Add back accidentally removed import.

    @cpovirk
    cpovirk committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ed75a1a View commit details
    Browse the repository at this point in the history

  3. Restore mocking for OutputStream only.

    @cpovirk
    cpovirk committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    60033ed View commit details
    Browse the repository at this point in the history