Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: CHANNEL_ID hash should be random for the channel (1.49.x backport) #9459

Merged
merged 1 commit into from
Aug 19, 2022
Merged

xds: CHANNEL_ID hash should be random for the channel (1.49.x backport) #9459

merged 1 commit into from
Aug 19, 2022

Commits on Aug 19, 2022

  1. xds: CHANNEL_ID hash should be random for the channel 

    The log id is an incrementing value starting from 0. That means the same
binary on two different machines will have the same hashes for each
consecutive Channel. That was not at all the intension of CHANNEL_ID.
From gRFC A42:

> This can be used in similar situations to where Envoy uses
> connection_properties to hash on the source IP address.
    @ejona86
    ejona86 committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    5b7d478 View commit details
    Browse the repository at this point in the history