Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: server stream should not deliver halfClose() when call is immediately cancelled(#9362) (v1.48 backport) #9417

Merged
merged 1 commit into from Jul 29, 2022

Conversation

YifeiZhuang
Copy link
Contributor

Fix a bug where the server stream delivers halfClose() to the call during cancellation. It happens when call has a short deadline. Server sees INTERNAL, desc: Half-closed without a request due to the bug.

backport of #9362

…iately cancelled(grpc#9362)

Fix a bug where the server stream delivers halfClose() to the call during cancellation. It happens when call has a short deadline. Server sees `INTERNAL, desc: Half-closed without a request` due to the bug.
@YifeiZhuang YifeiZhuang changed the title core: server stream should not deliver halfClose() when call is immediately cancelled(#9362) core: server stream should not deliver halfClose() when call is immediately cancelled(#9362) (v1.48 backport) Jul 28, 2022
@YifeiZhuang YifeiZhuang requested a review from ejona86 July 28, 2022 20:57
@YifeiZhuang YifeiZhuang merged commit d56f8fb into grpc:v1.48.x Jul 29, 2022
@YifeiZhuang YifeiZhuang deleted the backport-half-close branch July 29, 2022 16:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants