Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: do not expose orca proto in ORCA api (#9366) (v1.48 backport) #9412

Merged
merged 5 commits into from Jul 28, 2022
Merged

xds: do not expose orca proto in ORCA api (#9366) (v1.48 backport) #9412

merged 5 commits into from Jul 28, 2022

Conversation

YifeiZhuang
Copy link
Contributor

@YifeiZhuang YifeiZhuang commented Jul 26, 2022 •
edited

The fix avoids shaded dependency of orca protos

backport of #9366 #9382 #9403 #9410 #9411

@YifeiZhuang
xds: do not expose orca proto in ORCA api (grpc#9366)
e15bb3c 
The fix avoids shaded dependency of orca protos
@YifeiZhuang YifeiZhuang requested a review from ejona86 July 26, 2022 19:56
ejona86
ejona86 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to rebase. Do not squash; it'll make it harder to track that we've already backported.

@YifeiZhuang YifeiZhuang merged commit 80dc067 into grpc:v1.48.x Jul 28, 2022
@YifeiZhuang YifeiZhuang deleted the backport-orca-proto-fix branch July 28, 2022 21:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YifeiZhuang @ejona86