Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Workaround retry causing memory leak #9360

Merged
merged 2 commits into from Jul 15, 2022
Merged

core: Workaround retry causing memory leak #9360

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35f3013
core: Workaround retry causing memory leak
ejona86 Jul 11, 2022
07ed957
Fix tests
ejona86 Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/java/io/grpc/internal/RetriableStream.java
View file
Open in desktop
Expand Up @@ -550,6 +550,10 @@ class SendMessageEntry implements BufferEntry {
@Override
public void runWith(Substream substream) {
substream.stream.writeMessage(method.streamRequest(message));
// TODO(ejona): Workaround Netty memory leak. Message writes always need to be followed by
// flushes (or half close), but retry appears to have a code path that the flushes may
// not happen. The code needs to be fixed and this removed. See #9340.
substream.stream.flush();
}
}

Expand Down