Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp-observability: Populate global interceptors from observability #9309
gcp-observability: Populate global interceptors from observability #9309
Changes from all commits
935a02f
d407fdd
4d685d3
528c9f5
47d8125
6e713a0
fc45695
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are passing
observabilityConfig
to the non-staticgrpcInit
we can constructconfigFilterHelper
in there? Unless I am missing something?May be the same thing for many other objects being constructed here and passed to the non-static
grpcInit
such assink
helper
etc?The reason I am saying is because the non-static
grpcInit
is unit tested/unit-testable so the more code it has the better it is. But we need to look into it carefully