Commits on Jun 6, 2022

1. testing: Have GrpcCleanupRule extend ExternalResource …

   This allows using GrpcCleanupRule with JUnit 5 when combined with
   ExternalResourceSupport. We don't really lose anything important when
   running with JUnit 4 and this eases migration to JUnit 5.
   
   ExternalResource is now responsible for combining exceptions. after()
   cannot throw checked exceptions, so we must now wrap the
   InterruptedException. When used with JUnit 5 we are unable to detect the
   test failed; we accept that for now but it may be fair to create a new
   class for JUnit 5 to be used with `@RegisterExtension` that implements
   BeforeEachCallback and AfterTestExecutionCallback to restore the JUnit 4
   behavior.
   
   See grpc#5331

   

   ejona86 committed Jun 6, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for b32d438
   • Browse repository at this point

   Copy the full SHA

   b32d438 View commit details

   Browse the repository at this point in the history