Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: Make a copy of Metadata for thread safety. #9212

Merged
merged 1 commit into from May 25, 2022
Merged

xds: Make a copy of Metadata for thread safety. #9212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion xds/src/test/java/io/grpc/xds/FakeControlPlaneXdsIntegrationTest.java
View file
Open in desktop
Expand Up @@ -300,10 +300,15 @@ public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall(ServerCall<ReqT, Re
Metadata requestHeaders, ServerCallHandler<ReqT, RespT> next) {
logger.fine("Received following metadata: " + requestHeaders);

// Make a copy of the headers so that it can be read in a thread-safe manner when copying
// it to the response headers.
Metadata headersToReturn = new Metadata();
headersToReturn.merge(requestHeaders);

return next.startCall(new SimpleForwardingServerCall<ReqT, RespT>(call) {
@Override
public void sendHeaders(Metadata responseHeaders) {
responseHeaders.merge(requestHeaders);
responseHeaders.merge(headersToReturn);
super.sendHeaders(responseHeaders);
}

Expand Down