Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send empty shutdown flags to avoid a binder memory leak #8728

Merged
merged 2 commits into from Dec 1, 2021
Merged

Send empty shutdown flags to avoid a binder memory leak #8728

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59dcd6e
Send empty shutdown flags to avoid a binder leak
jdcormie Nov 29, 2021
b151fae
Add bug number
jdcormie Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions binder/src/main/java/io/grpc/binder/internal/BinderTransport.java
View file
Open in desktop
Expand Up @@ -345,6 +345,8 @@ private final void sendShutdownTransaction() {
// Ignore.
}
Parcel parcel = Parcel.obtain();
// Send empty flags to avoid a memory leak linked to empty parcels (b/207778694).
parcel.writeInt(0);
try {
outgoingBinder.transact(SHUTDOWN_TRANSPORT, parcel, null, IBinder.FLAG_ONEWAY);
} catch (RemoteException re) {
Expand Down