Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: import v3 RBAC http filter proto #8215

Merged
merged 1 commit into from May 27, 2021

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented May 27, 2021

#8145 only brings in RBAC configuration protos, but not the http filter protos. We may want to bring in v2 protos as we did for fault injection protos, in case TD sends responses with v2 messages. That would be for logging purposes only and we are not sure if they are necessary. So just import v3 protos for now.

@voidzcy voidzcy changed the title xds: import up Envoy protos (delete unsupported v2 fault filter and add v3 RBAC filter) xds: clean up Envoy protos (delete unsupported v2 fault filter and add v3 RBAC filter) May 27, 2021
@voidzcy voidzcy force-pushed the import/clean_up_http_filter_protos branch from c1b5e4e to ee55363 Compare May 27, 2021 06:16
@voidzcy voidzcy changed the title xds: clean up Envoy protos (delete unsupported v2 fault filter and add v3 RBAC filter) xds: import v3 RBAC http filter proto May 27, 2021
@voidzcy voidzcy merged commit 8129c4e into grpc:master May 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants