Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Guava 30.1, which warns on Java 7 #8100

Merged
merged 1 commit into from Apr 19, 2021
Merged

Commits on Apr 16, 2021

  1. Upgrade to Guava 30.1, which warns on Java 7

    This change can have large impact from two aspects:
    1. It calls out a _large_ impact on the _few_ Java 7 users.
    2. It may have _small_ impact on the _many_ Android users.
    
    grpc#4671 tracks gRPC's removal of
    Java 7 support. We are quite eager to drop Java 7 support as that would
    allow using new language features like default methods. Guava is also
    dropping Java 7 support and starting in 30.1 it will warn when used on
    Java 7. The purpose of the warning is to help discover users that are
    negatively impacted by dropping Java 7 before it becomes a bigger
    problem.
    
    The Guava logging check was implemented in such a way that there is an
    optional class that uses Java 8 bytecode. While the class is optional at
    runtime, the Android build system notices when dexing and fails if
    Java 8 language featutres are not enabled. We believe this will not be a
    problem for most Android users, but they may need to add to their build:
    
    ```
    android {
        compileOptions {
            sourceCompatibility JavaVersion.VERSION_1_8
            targetCompatibility JavaVersion.VERSION_1_8
        }
    }
    ```
    
    See also https://github.com/google/guava/releases/tag/v30.1
    ejona86 committed Apr 16, 2021
    Copy the full SHA
    b3d7595 View commit details
    Browse the repository at this point in the history