Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Google auth library to 0.25.2 with dependency exclusion #8078

Closed
wants to merge 6 commits into from

Commits on Apr 12, 2021

  1. Configuration menu
    Copy the full SHA
    ec8d191 View commit details
    Browse the repository at this point in the history
  2. Dependency override

    suztomo committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    c8e0264 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dbe557f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Exclusion for httpcore rather than overwriting it

    It's preferred to setup dependency exclusions and declare the
    problematic dependency as a direct dependency, because overwriting
    the dependency (in this case org.apache.httpcomponents:httpcore),
    while it may pass the checks in the build, does not have any
    effect in the produced pom.xml after the library is published
    to Maven Central.
    suztomo committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    26079a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b19fc94 View commit details
    Browse the repository at this point in the history
  3. Excluding junit from google-http-client-jackson2

    Google-http-client-jackson2 depends on jackson-core.
    Jackson-core depends on junit (with test scope).
    If we don't exclude the junit dependency, :grpc-all:dependencies
    (unexpectedly) fails to resolve dependencies. Details:
    grpc#8078 (comment)
    suztomo committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    009f6f5 View commit details
    Browse the repository at this point in the history