Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, grpclb,xds: let leaf LB policies explicitly refresh name resolution when subchannel connection is broken #8048

Merged
merged 15 commits into from Apr 16, 2021
Merged

core, grpclb,xds: let leaf LB policies explicitly refresh name resolution when subchannel connection is broken #8048

merged 15 commits into from Apr 16, 2021

Commits on Apr 2, 2021

  1. Do not implicitly refresh name resolution when subchannel connection … 

    …is broken, let LB policies handle it.
    @voidzcy
    voidzcy committed Apr 2, 2021
    Copy the full SHA
    4743bc8 View commit details
    Browse the repository at this point in the history

  2. Add subchannel refreshing name resolution when connection broken logi… 

    …c in pick_first.
    @voidzcy
    voidzcy committed Apr 2, 2021
    Copy the full SHA
    1305135 View commit details
    Browse the repository at this point in the history

  3. Add subchannel refreshing name resolution when connection broken logi… 

    …c in round_robin.
    @voidzcy
    voidzcy committed Apr 2, 2021
    Copy the full SHA
    6c7f2f3 View commit details
    Browse the repository at this point in the history

  4. Add subchannel refreshing name resolution when connection broken logi… 

    …c in grpclb.
    @voidzcy
    voidzcy committed Apr 2, 2021
    Copy the full SHA
    b6633e6 View commit details
    Browse the repository at this point in the history

  5. Fix mock in RLS test.

    @voidzcy
    voidzcy committed Apr 2, 2021
    Copy the full SHA
    8f3f060 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Merge branch 'master' of https://github.com/grpc/grpc-java into bugfi… 

    …x/move_subchannel_refreshing_ns_to_lb
    @voidzcy
    voidzcy committed Apr 9, 2021
    Copy the full SHA
    826f6e1 View commit details
    Browse the repository at this point in the history

  2. Add subchannel refreshing name resolution when connection broken logi… 

    …c in ring hash LB policy.
    @voidzcy
    voidzcy committed Apr 9, 2021
    Copy the full SHA
    a3b5e13 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Add ignoreRefreshNameResolutionCheck() API to skip warning and Channe… 

    …l's refresh for cases LoadBalancer intentionally does not want a refresh.
    @voidzcy
    voidzcy committed Apr 15, 2021
    Copy the full SHA
    be2386c View commit details
    Browse the repository at this point in the history

  2. Check if refreshNameResolution() has been called by the LoadBalancer … 

    …when handling subchannel state changes. Log a warning and do a refresh if it is not.
    @voidzcy
    voidzcy committed Apr 15, 2021
    Copy the full SHA
    fd1b608 View commit details
    Browse the repository at this point in the history

  3. The cluster_resolver LB policy intentionally does not want to trigger… 

    … a name resolution refresh for the resolver in Channel, so use ignoreRefreshNameResolutionCheck() to avoid false-positive warnings.
    @voidzcy
    voidzcy committed Apr 15, 2021
    Copy the full SHA
    2ff23c6 View commit details
    Browse the repository at this point in the history

  4. Add proper annotation.

    @voidzcy
    voidzcy committed Apr 15, 2021
    Copy the full SHA
    cf5af02 View commit details
    Browse the repository at this point in the history

  5. Improve warning message.

    @voidzcy
    voidzcy committed Apr 15, 2021
    Copy the full SHA
    e443a78 View commit details
    Browse the repository at this point in the history

  6. Make LoadBalancer.Helper.ignoreRefreshNameResolutionCheck() default t… 

    …o no-op, update its doc and not mark it as deprecated for now.
    @voidzcy
    voidzcy committed Apr 15, 2021
    Copy the full SHA
    417532f View commit details
    Browse the repository at this point in the history

  7. Add TODO note for changing LB policies manage name resolution refresh… 

    … for OOB channel state changes.
    @voidzcy
    voidzcy committed Apr 15, 2021
    Copy the full SHA
    522d545 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Fix warning message check test.

    @voidzcy
    voidzcy committed Apr 16, 2021
    Copy the full SHA
    8312c61 View commit details
    Browse the repository at this point in the history