Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpclb: should not ignore subchannels with CONNECTING state in aggregating the overall LB state #7959

Merged
merged 1 commit into from Mar 12, 2021
Merged

grpclb: should not ignore subchannels with CONNECTING state in aggregating the overall LB state #7959

merged 1 commit into from Mar 12, 2021

Commits on Mar 12, 2021

  1. Fix bug of ignoring subchannels with CONNECTING state when aggregatin… 

    …g the overall load balancing state.

We should treat both IDLE and CONNECTING subchannels as "connection in progress" when aggregating for the overall load balancing state. Otherwise, RPCs could fail prematurely if one subchannel enters TF while all the others are still in CONNECTING.

23d2796 made each individual subchannel stay in TF until READY if it previously was in TF. So subchannels with CONNECTING state are those in first time connecting. We should give them time to connect.
    @voidzcy
    voidzcy committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    29de6df View commit details
    Browse the repository at this point in the history