Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop-testing: fix alts handshaking race #7896

Merged
merged 4 commits into from Feb 12, 2021

Conversation

YifeiZhuang
Copy link
Contributor

@YifeiZhuang YifeiZhuang commented Feb 12, 2021

https://travis-ci.org/github/grpc/grpc-java/jobs/758605192

io.grpc.testing.integration.AltsHandshakerTest > testAlts FAILED
    io.grpc.StatusRuntimeException: UNKNOWN
        at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262)
        at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243)
        at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156)
        at io.grpc.testing.integration.TestServiceGrpc$TestServiceBlockingStub.unaryCall(TestServiceGrpc.java:624)
        at io.grpc.testing.integration.AltsHandshakerTest.testAlts(AltsHandshakerTest.java:98)
        Caused by:
        io.grpc.netty.shaded.io.netty.handler.codec.DecoderException: java.lang.IllegalArgumentException: Invalid header field: frame size too small
            at io.grpc.netty.shaded.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:471)
            at io.grpc.netty.shaded.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
            at io.grpc.netty.shaded.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
            at io.grpc.netty.shaded.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
            at io.grpc.netty.shaded.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
            at io.grpc.netty.shaded.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
            at io.grpc.netty.shaded.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
            at io.grpc.netty.shaded.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
            at io.grpc.netty.shaded.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
            at io.grpc.netty.shaded.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795)
            at io.grpc.netty.shaded.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:475)
            at io.grpc.netty.shaded.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)
            at io.grpc.netty.shaded.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
            at io.grpc.netty.shaded.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
            at io.grpc.netty.shaded.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
            at java.lang.Thread.run(Thread.java:748)
            Caused by:
            java.lang.IllegalArgumentException: Invalid header field: frame size too small
                at com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
                at io.grpc.alts.internal.AltsTsiFrameProtector$Unprotector.handleHeader(AltsTsiFrameProtector.java:267)
                at io.grpc.alts.internal.AltsTsiFrameProtector$Unprotector.decodeFrame(AltsTsiFrameProtector.java:235)
                at io.grpc.alts.internal.AltsTsiFrameProtector$Unprotector.unprotect(AltsTsiFrameProtector.java:224)
                at io.grpc.alts.internal.AltsTsiFrameProtector.unprotect(AltsTsiFrameProtector.java:91)
                at io.grpc.alts.internal.TsiFrameHandler.decode(TsiFrameHandler.java:63)
                at io.grpc.netty.shaded.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:501)
                at io.grpc.netty.shaded.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:440)
                ... 15 more

@YifeiZhuang YifeiZhuang changed the title fix server finish first interop-testing: fix alts handshaking race Feb 12, 2021
@YifeiZhuang YifeiZhuang merged commit 0d2ea93 into grpc:master Feb 12, 2021
@YifeiZhuang
Copy link
Contributor Author

Related to #7847

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
@YifeiZhuang YifeiZhuang deleted the zivy/fix_alts_handshake branch June 10, 2021 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants