Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: DelayedStream should start() real stream immediately #7750

Merged
merged 3 commits into from Jan 20, 2021
Merged

core: DelayedStream should start() real stream immediately #7750

merged 3 commits into from Jan 20, 2021

Commits on Dec 22, 2020

  1. core: DelayedStream should start() real stream immediately 

    DelayedClientTransport needs to avoid becoming terminated while it owns
RPCs. Previously DelayedClientTransport could terminate when some of its
RPCs had their realStream but realStream.start() hadn't yet been called.

To avoid that, we now make sure to call realStream.start()
synchronously with setting realStream. Since start() and the method
calls before start execute quickly, we can run it in-line. But it does
mean we now need to split the Stream methods into "before start" and
"after start" categories for queuing.

Fixes grpc#6283
    @ejona86
    ejona86 committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    e8ffac7 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Remove unnecessary listenerToClose variable

    @ejona86
    ejona86 committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    2f8cd49 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. core: Avoid calling cancel() before start()

    @ejona86
    ejona86 committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    a60d92b View commit details
    Browse the repository at this point in the history