-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api,core: Add ServerInterceptor2 interface #7746
Open
ericgribkoff
wants to merge
4
commits into
grpc:master
Choose a base branch
from
ericgribkoff:server_interceptor_2
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/* | ||
* Copyright 2020 The gRPC Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.grpc; | ||
|
||
import javax.annotation.concurrent.ThreadSafe; | ||
|
||
/** | ||
* Interface for intercepting server calls by modifying the {@link ServerMethodDefinition} after | ||
* method lookup and before call dispatch. This provides a superset of the functionality offered by | ||
* {@link ServerInterceptor}. | ||
*/ | ||
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/????") | ||
@ThreadSafe | ||
public interface ServerInterceptor2 { | ||
/** | ||
* Intercept and modify the {@link ServerMethodDefinition}. | ||
* | ||
* <p>The returned ServerMethodDefinition cannot be null and implementations must not throw. | ||
*/ | ||
<ReqT, RespT> ServerMethodDefinition<ReqT, RespT> interceptMethodDefinition( | ||
ServerMethodDefinition<ReqT, RespT> method); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,9 @@ | |
|
||
package io.grpc; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
/** | ||
* Definition of a method exposed by a {@link Server}. | ||
* | ||
|
@@ -24,11 +27,13 @@ | |
public final class ServerMethodDefinition<ReqT, RespT> { | ||
private final MethodDescriptor<ReqT, RespT> method; | ||
private final ServerCallHandler<ReqT, RespT> handler; | ||
private final List<ServerStreamTracer.Factory> streamTracerFactories; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This class must not be mutable. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
|
||
private ServerMethodDefinition(MethodDescriptor<ReqT, RespT> method, | ||
ServerCallHandler<ReqT, RespT> handler) { | ||
this.method = method; | ||
this.handler = handler; | ||
this.streamTracerFactories = new ArrayList<>(); | ||
} | ||
|
||
/** | ||
|
@@ -64,4 +69,16 @@ public ServerMethodDefinition<ReqT, RespT> withServerCallHandler( | |
ServerCallHandler<ReqT, RespT> handler) { | ||
return new ServerMethodDefinition<>(method, handler); | ||
} | ||
|
||
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/????") | ||
public ServerMethodDefinition<ReqT, RespT> | ||
addStreamTracerFactory(ServerStreamTracer.Factory factory) { | ||
streamTracerFactories.add(factory); | ||
return this; | ||
} | ||
|
||
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/????") | ||
public List<? extends ServerStreamTracer.Factory> getStreamTracerFactories() { | ||
return streamTracerFactories; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to be able to mix ServerInterceptor and ServerInterceptor2 together, such that they are run in the order added, not in two stages. I imagine that would be implemented by converting ServerInterceptors to ServerInterceptor2 when being added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is much clearer. Done.